Display imp for ClientIpSource - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Display impl for ClientIpSource, and a unit test to ensure that
Display==FromStr.Currently the test has to have the variants manually listed. I appreciate this is not ideal since new variants can be added to the enum and the test would still pass. Best alternative I can think of is to create a proc-macro which generates the test, something I didn't want to do without at least talking to you first.
My usecase should you be interested is declaring a default value for an arg with clap.
For some reason they appear to be using the
ToStringtrait and then comparing the result of that rather than usingFromStr.Appreciate your work on this crate!